Skip to content

Conversation

@localheinz
Copy link
Contributor

@localheinz localheinz commented Jul 15, 2022

This pull request

  • includes *.inc files when running friendsofphp/php-cs-fixer
  • runs make coding-standards

Follows #559.

πŸ’β€β™‚οΈ A lot of whitespace changes, so perhaps best reviewed using https://github.com/php/web-php/pull/662/files?w=1.

@localheinz localheinz marked this pull request as ready for review July 15, 2022 11:43
@localheinz localheinz changed the title Enhancement: Include *.inc files Enhancement: Include *.inc files (with exceptions) Jul 15, 2022
Copy link
Member

@kamil-tekiela kamil-tekiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense. I can see only whitespace changes.

@cmb69 cmb69 merged commit b575ebd into php:master Jul 15, 2022
@cmb69
Copy link
Member

cmb69 commented Jul 15, 2022

Thank you!

@localheinz localheinz deleted the feature/inc branch July 15, 2022 11:59
@localheinz
Copy link
Contributor Author

Thank you, @cmb69 and @kamil-tekiela!

@cmb69
Copy link
Member

cmb69 commented Jul 15, 2022

Oh, that failed the CS check: https://github.com/php/web-php/runs/7357443033?check_suite_focus=true. Should be fixed by 5c9eab2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants